botaccount
/
limboai
mirror of https://github.com/limbonaut/limboai.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize TreeSearch::_filter_tree for performance

This commit is contained in:
Alexander Montag 2024-09-30 19:23:49 +02:00
parent 8d781da1a6
commit e6e1addbcb
No known key found for this signature in database
GPG Key ID: 07FE50B35A2B7524
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
editor/tree_search.cpp
View File

@ -68,10 +68,16 @@ void TreeSearch::_filter_tree(const String &p_search_mask) {
} }
TreeItem *first_counting_ancestor = cur_item; TreeItem *first_counting_ancestor = cur_item;
bool parents_visible = true;
while (first_counting_ancestor && !number_matches.has(first_counting_ancestor)) { while (first_counting_ancestor && !number_matches.has(first_counting_ancestor)) {
// Performance: we only need to check the first visible ancestor. This is already optimal because of the ordering in ordered_tree_items.
if (!first_counting_ancestor->is_visible()){
parents_visible = false;
break;
}
first_counting_ancestor = first_counting_ancestor->get_parent(); first_counting_ancestor = first_counting_ancestor->get_parent();
} }
if (!first_counting_ancestor || !_vector_has_bsearch(matching_entries, first_counting_ancestor)) { if (!parents_visible || !first_counting_ancestor || !_vector_has_bsearch(matching_entries, first_counting_ancestor)) {
cur_item->set_visible(false); cur_item->set_visible(false);
} }
} }