From cbd467f97fec02d23c3274a5f4775e5e5c78c776 Mon Sep 17 00:00:00 2001
From: Serhii Snitsaruk <limbonaut@pm.me>
Date: Wed, 13 Mar 2024 22:00:50 +0100
Subject: [PATCH] Blackboard: Assigning variables via code might have no effect
 if done before initialization

---
 blackboard/blackboard_plan.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/blackboard/blackboard_plan.cpp b/blackboard/blackboard_plan.cpp
index 6d8b723..0e27a2d 100644
--- a/blackboard/blackboard_plan.cpp
+++ b/blackboard/blackboard_plan.cpp
@@ -328,12 +328,8 @@ Ref<Blackboard> BlackboardPlan::create_blackboard(Node *p_node) {
 void BlackboardPlan::populate_blackboard(const Ref<Blackboard> &p_blackboard, bool overwrite, Node *p_node) {
 	ERR_FAIL_COND(p_node == nullptr && prefetch_nodepath_vars);
 	for (const Pair<StringName, BBVariable> &p : var_list) {
-		if (p_blackboard->has_var(p.first)) {
-			if (overwrite) {
-				p_blackboard->erase_var(p.first);
-			} else {
-				continue;
-			}
+		if (p_blackboard->has_var(p.first) && !overwrite) {
+			continue;
 		}
 		bb_add_var_dup_with_prefetch(p_blackboard, p.first, p.second, prefetch_nodepath_vars, p_node);
 	}