Improve readability of TreeSearch

This commit is contained in:
Alexander Montag 2024-09-29 00:08:24 +00:00
parent c909582480
commit cb163ebc38
2 changed files with 5 additions and 3 deletions

View File

@ -205,8 +205,8 @@ void TreeSearch::_update_number_matches() {
for (int i = 0; i < matching_entries.size(); i++) { for (int i = 0; i < matching_entries.size(); i++) {
TreeItem *item = matching_entries[i]; TreeItem *item = matching_entries[i];
while (item) { while (item) {
int old_num_value = number_matches.has(item) ? number_matches.get(item) : 0; int previous_match_cnt = number_matches.has(item) ? number_matches.get(item) : 0;
number_matches[item] = old_num_value + 1; number_matches[item] = previous_match_cnt + 1;
item = item->get_parent(); item = item->get_parent();
} }
} }
@ -253,8 +253,10 @@ TreeSearch::StringSearchIndices TreeSearch::_substring_bounds(const String &p_se
// Determine if the search should be case-insensitive. // Determine if the search should be case-insensitive.
bool is_case_insensitive = (p_search_mask == p_search_mask.to_lower()); bool is_case_insensitive = (p_search_mask == p_search_mask.to_lower());
String searchable_processed = is_case_insensitive ? p_searchable.to_lower() : p_searchable; String searchable_processed = is_case_insensitive ? p_searchable.to_lower() : p_searchable;
PackedStringArray words = p_search_mask.split(" "); PackedStringArray words = p_search_mask.split(" ");
int word_position = 0; int word_position = 0;
for (const String &word : words) { for (const String &word : words) {
if (word.is_empty()) { if (word.is_empty()) {
continue; // Skip empty words. continue; // Skip empty words.

View File

@ -92,7 +92,7 @@ public:
void update_search(Tree *p_tree); void update_search(Tree *p_tree);
void notify_item_edited(TreeItem *p_item); void notify_item_edited(TreeItem *p_item);
TreeSearch() { ERR_FAIL_MSG("TreeSearch needs a TreeSearchPanel to work properly"); } TreeSearch() { ERR_FAIL_MSG("TreeSearch needs a TreeSearchPanel to work properly."); }
TreeSearch(TreeSearchPanel *p_search_panel); TreeSearch(TreeSearchPanel *p_search_panel);
}; };