From 8dc645c9a72d1a556a2319177b2379ba7e88ea1c Mon Sep 17 00:00:00 2001
From: Serhii Snitsaruk <limbonaut@pm.me>
Date: Sat, 3 Feb 2024 17:28:56 +0100
Subject: [PATCH] Fix issues and update docs for BehaviorTreeData/View

---
 config.py                              |  1 +
 doc_classes/BTPlayer.xml               |  6 ++++++
 doc_classes/BTState.xml                |  8 ++++++++
 doc_classes/BehaviorTreeData.xml       | 22 ++++++++++++++++++++++
 doc_classes/BehaviorTreeView.xml       | 20 ++++++++++++++++++++
 editor/debugger/behavior_tree_data.cpp |  4 ++--
 editor/debugger/behavior_tree_view.cpp |  1 -
 7 files changed, 59 insertions(+), 3 deletions(-)
 create mode 100644 doc_classes/BehaviorTreeData.xml
 create mode 100644 doc_classes/BehaviorTreeView.xml

diff --git a/config.py b/config.py
index 458072f..875d0d3 100644
--- a/config.py
+++ b/config.py
@@ -58,6 +58,7 @@ def get_doc_classes():
         "BBVector4",
         "BBVector4i",
         "BehaviorTree",
+        "BehaviorTreeData",
         "BehaviorTreeView",
         "Blackboard",
         "BlackboardPlan",
diff --git a/doc_classes/BTPlayer.xml b/doc_classes/BTPlayer.xml
index a284468..090712d 100644
--- a/doc_classes/BTPlayer.xml
+++ b/doc_classes/BTPlayer.xml
@@ -16,6 +16,12 @@
 				Returns the behavior tree's last execution status. See [enum BT.Status].
 			</description>
 		</method>
+		<method name="get_tree_instance">
+			<return type="BTTask" />
+			<description>
+				Returns the root task of the instantiated behavior tree.
+			</description>
+		</method>
 		<method name="restart">
 			<return type="void" />
 			<description>
diff --git a/doc_classes/BTState.xml b/doc_classes/BTState.xml
index 7990803..80a490e 100644
--- a/doc_classes/BTState.xml
+++ b/doc_classes/BTState.xml
@@ -8,6 +8,14 @@
 	</description>
 	<tutorials>
 	</tutorials>
+	<methods>
+		<method name="get_tree_instance" qualifiers="const">
+			<return type="BTTask" />
+			<description>
+				Returns the root task of the instantiated behavior tree.
+			</description>
+		</method>
+	</methods>
 	<members>
 		<member name="behavior_tree" type="BehaviorTree" setter="set_behavior_tree" getter="get_behavior_tree">
 			A [BehaviorTree] resource that defines state behavior.
diff --git a/doc_classes/BehaviorTreeData.xml b/doc_classes/BehaviorTreeData.xml
new file mode 100644
index 0000000..67c5e6e
--- /dev/null
+++ b/doc_classes/BehaviorTreeData.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<class name="BehaviorTreeData" inherits="RefCounted" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../doc/class.xsd">
+	<brief_description>
+        Represents current state of a [BehaviorTree] instance.
+	</brief_description>
+	<description>
+        This class is used by the LimboAI debugger for the serialization and deserialization of [BehaviorTree] instance data.
+        Additionally, it can be used with [BehaviorTreeView] to visualize the current state of a [BehaviorTree] instance. It is meant to be utilized in custom in-game tools.
+	</description>
+	<tutorials>
+	</tutorials>
+	<methods>
+		<method name="create_from_tree_instance" qualifiers="static">
+			<return type="BehaviorTreeData" />
+			<param index="0" name="p_tree_instance" type="BTTask" />
+			<description>
+                Returns current state of the [param p_tree_instance] encoded as a [BehaviorTreeData], suitable for use with [BehaviorTreeView].
+                Behavior tree instance can be acquired with [method BTPlayer.get_tree_instance].
+			</description>
+		</method>
+	</methods>
+</class>
diff --git a/doc_classes/BehaviorTreeView.xml b/doc_classes/BehaviorTreeView.xml
new file mode 100644
index 0000000..3afa8d0
--- /dev/null
+++ b/doc_classes/BehaviorTreeView.xml
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<class name="BehaviorTreeView" inherits="Control" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../doc/class.xsd">
+	<brief_description>
+        Visualizes the current state of a [BehaviorTree] instance.
+	</brief_description>
+	<description>
+        Visualizes the current state of a [BehaviorTree] instance. See also [BehaviorTreeData].
+	</description>
+	<tutorials>
+	</tutorials>
+	<methods>
+		<method name="update_tree">
+			<return type="void" />
+			<param index="0" name="p_behavior_tree_data" type="BehaviorTreeData" />
+			<description>
+                Updates the representation of a [BehaviorTree] instance. See also [BehaviorTreeData].
+			</description>
+		</method>
+	</methods>
+</class>
diff --git a/editor/debugger/behavior_tree_data.cpp b/editor/debugger/behavior_tree_data.cpp
index 47a7cab..9626bb4 100644
--- a/editor/debugger/behavior_tree_data.cpp
+++ b/editor/debugger/behavior_tree_data.cpp
@@ -120,8 +120,8 @@ Ref<BehaviorTreeData> BehaviorTreeData::create_from_tree_instance(const Ref<BTTa
 }
 
 void BehaviorTreeData::_bind_methods() {
-	ClassDB::bind_static_method("BehaviorTreeData", D_METHOD("serialize", "p_tree_instance", "p_player_path", "p_bt_resource_path"), &BehaviorTreeData::serialize);
-	ClassDB::bind_static_method("BehaviorTreeData", D_METHOD("deserialize", "p_array"), &BehaviorTreeData::deserialize);
+	// ClassDB::bind_static_method("BehaviorTreeData", D_METHOD("serialize", "p_tree_instance", "p_player_path", "p_bt_resource_path"), &BehaviorTreeData::serialize);
+	// ClassDB::bind_static_method("BehaviorTreeData", D_METHOD("deserialize", "p_array"), &BehaviorTreeData::deserialize);
 	ClassDB::bind_static_method("BehaviorTreeData", D_METHOD("create_from_tree_instance", "p_tree_instance"), &BehaviorTreeData::create_from_tree_instance);
 }
 
diff --git a/editor/debugger/behavior_tree_view.cpp b/editor/debugger/behavior_tree_view.cpp
index cf61278..1393c3d 100644
--- a/editor/debugger/behavior_tree_view.cpp
+++ b/editor/debugger/behavior_tree_view.cpp
@@ -186,7 +186,6 @@ void BehaviorTreeView::_notification(int p_what) {
 		case NOTIFICATION_READY: {
 			tree->connect(LW_NAME(item_collapsed), callable_mp(this, &BehaviorTreeView::_item_collapsed));
 		} break;
-		case NOTIFICATION_POSTINITIALIZE:
 		case NOTIFICATION_LAYOUT_DIRECTION_CHANGED:
 		case NOTIFICATION_TRANSLATION_CHANGED:
 		case NOTIFICATION_THEME_CHANGED: {