Fix BTState overwriting blackboard variables on init
This commit is contained in:
parent
d7438b8a8d
commit
7e83c1f246
|
@ -13,6 +13,7 @@
|
|||
#define BLACKBOARD_H
|
||||
|
||||
#include "bb_variable.h"
|
||||
#include "core/typedefs.h"
|
||||
|
||||
#ifdef LIMBOAI_MODULE
|
||||
#include "core/object/object.h"
|
||||
|
@ -49,6 +50,7 @@ public:
|
|||
Variant get_var(const StringName &p_name, const Variant &p_default = Variant(), bool p_complain = true) const;
|
||||
void set_var(const StringName &p_name, const Variant &p_value);
|
||||
bool has_var(const StringName &p_name) const;
|
||||
_FORCE_INLINE_ bool has_local_var(const StringName &p_name) const { return data.has(p_name); }
|
||||
void erase_var(const StringName &p_name);
|
||||
void clear() { data.clear(); }
|
||||
TypedArray<StringName> list_vars() const;
|
||||
|
|
|
@ -416,7 +416,7 @@ void BlackboardPlan::populate_blackboard(const Ref<Blackboard> &p_blackboard, bo
|
|||
ERR_FAIL_COND(p_node == nullptr && prefetch_nodepath_vars);
|
||||
ERR_FAIL_COND(p_blackboard.is_null());
|
||||
for (const Pair<StringName, BBVariable> &p : var_list) {
|
||||
if (p_blackboard->has_var(p.first) && !overwrite) {
|
||||
if (p_blackboard->has_local_var(p.first) && !overwrite) {
|
||||
continue;
|
||||
}
|
||||
bool has_mapping = parent_scope_mapping.has(p.first);
|
||||
|
|
|
@ -183,6 +183,7 @@ void BTPlayer::_notification(int p_notification) {
|
|||
blackboard = Ref<Blackboard>(memnew(Blackboard));
|
||||
}
|
||||
if (blackboard_plan.is_valid()) {
|
||||
// Don't overwrite existing blackboard values as they may be initialized from code.
|
||||
blackboard_plan->populate_blackboard(blackboard, false, this);
|
||||
}
|
||||
if (behavior_tree.is_valid()) {
|
||||
|
|
|
@ -95,7 +95,8 @@ void LimboState::_initialize(Node *p_agent, const Ref<Blackboard> &p_blackboard)
|
|||
blackboard = p_blackboard;
|
||||
}
|
||||
if (blackboard_plan.is_valid() && !blackboard_plan->is_empty()) {
|
||||
blackboard_plan->populate_blackboard(blackboard, true, this);
|
||||
// Don't overwrite existing blackboard values as they may be initialized from code.
|
||||
blackboard_plan->populate_blackboard(blackboard, false, this);
|
||||
}
|
||||
|
||||
_setup();
|
||||
|
|
Loading…
Reference in New Issue