From 2c58cfc3cba0c95f5592d8ba064b517d9a215d33 Mon Sep 17 00:00:00 2001
From: Serhii Snitsaruk <limbonaut@pm.me>
Date: Wed, 31 Jul 2024 10:46:53 +0200
Subject: [PATCH] GHA: Don't strip binaries, done at build time

---
 .github/workflows/gdextension.yml | 13 -------------
 .github/workflows/ios.yml         |  3 ---
 .github/workflows/linux.yml       |  5 -----
 .github/workflows/macos.yml       |  5 -----
 4 files changed, 26 deletions(-)

diff --git a/.github/workflows/gdextension.yml b/.github/workflows/gdextension.yml
index 44db582..e27e397 100644
--- a/.github/workflows/gdextension.yml
+++ b/.github/workflows/gdextension.yml
@@ -287,19 +287,6 @@ jobs:
           echo "---"
           ls -R out/
 
-      - name: Strip lib
-        if: matrix.opts.platform != 'windows' && matrix.opts.platform != 'web' && (matrix.opts.platform != 'android' || startsWith(matrix.opts.arch, 'x86'))
-        run: |
-          ls -l -R out/addons/limboai/bin/
-          echo "---"
-          if [ "$RUNNER_OS" == "macOS" ]; then
-            strip -u out/addons/limboai/bin/liblimboai*/liblimboai*
-          else
-            strip out/addons/limboai/bin/liblimboai*
-          fi
-          echo "---"
-          ls -l -R out/addons/limboai/bin/
-
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         env:
diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml
index 6f484a5..cbcc1fb 100644
--- a/.github/workflows/ios.yml
+++ b/.github/workflows/ios.yml
@@ -170,9 +170,6 @@ jobs:
           cp -r misc/dist/ios_xcode bin/
           cd bin/
 
-          # --- Note: Doesn't look like libs need stripping ---
-          # strip *.a
-
           mv libgodot.ios.template_debug.arm64.a ios_xcode/libgodot.ios.debug.xcframework/ios-arm64/libgodot.a
           # ! lipo -create libgodot.ios.template_debug.arm64.simulator.a libgodot.ios.template_debug.x86_64.simulator.a -output ios_xcode/libgodot.ios.debug.xcframework/ios-arm64_x86_64-simulator/libgodot.a
           mv libgodot.ios.template_debug.x86_64.simulator.a ios_xcode/libgodot.ios.debug.xcframework/ios-arm64_x86_64-simulator/libgodot.a
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
index 79a0343..ef48347 100644
--- a/.github/workflows/linux.yml
+++ b/.github/workflows/linux.yml
@@ -233,11 +233,6 @@ jobs:
         env:
           OUTDIR: ${{ startsWith(matrix.opts.target, 'template') && 'out/templates' || 'out/' }}
         run: |
-          if [ "${{matrix.opts.arch}}" == "arm64" ]; then
-            ${GITHUB_WORKSPACE}/buildroot/bin/aarch64-godot-linux-gnu-strip ./bin/godot.*
-          else
-            strip ./bin/godot.*
-          fi
           chmod +x ./bin/godot.*
           mkdir -p ${{env.OUTDIR}}
           mv bin/* ${{env.OUTDIR}}
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
index 92b9aec..a0980ad 100644
--- a/.github/workflows/macos.yml
+++ b/.github/workflows/macos.yml
@@ -199,7 +199,6 @@ jobs:
 
       - name: Prepare artifact
         run: |
-          strip bin/godot.*
           chmod +x bin/godot.*
 
       - name: Upload artifact
@@ -257,9 +256,6 @@ jobs:
         run: |
           ls bin/
           lipo -create bin/godot.macos.editor.x86_64* bin/godot.macos.editor.arm64* -output bin/godot.macos.editor.universal
-          du -sh bin/
-          strip bin/godot.macos.editor.universal
-          du -sh bin/
           mkdir -p out/editor/
           cp -r misc/dist/macos_tools.app out/editor/${APP_NAME}
           mkdir -p out/editor/${APP_NAME}/Contents/{MacOS,Resources}
@@ -295,7 +291,6 @@ jobs:
           ls bin/
           lipo -create bin/godot.macos.template_release.x86_64* bin/godot.macos.template_release.arm64* -output bin/godot.macos.template_release.universal
           lipo -create bin/godot.macos.template_debug.x86_64* bin/godot.macos.template_debug.arm64* -output bin/godot.macos.template_debug.universal
-          strip bin/godot.*.universal
           cp -r misc/dist/macos_template.app macos_template.app
           mkdir -p macos_template.app/Contents/MacOS
           cp bin/godot.macos.template_debug.universal macos_template.app/Contents/MacOS/godot_macos_debug.universal