From 011040e46ff6f60e9060c08b20d53cef938378e4 Mon Sep 17 00:00:00 2001 From: Serhii Snitsaruk Date: Sun, 28 Jan 2024 21:58:18 +0100 Subject: [PATCH] Editor: Distinguish private variables in the inspector --- editor/editor_property_variable_name.cpp | 4 ++++ editor/editor_property_variable_name.h | 1 + gdextension/limboai.gdextension | 1 + util/limbo_string_names.cpp | 1 + util/limbo_string_names.h | 1 + 5 files changed, 8 insertions(+) diff --git a/editor/editor_property_variable_name.cpp b/editor/editor_property_variable_name.cpp index 34d52e1..13cba3e 100644 --- a/editor/editor_property_variable_name.cpp +++ b/editor/editor_property_variable_name.cpp @@ -72,6 +72,9 @@ void EditorPropertyVariableName::_update_status() { if (plan->has_var(name_edit->get_text())) { BUTTON_SET_ICON(status_btn, theme_cache.var_exists_icon); status_btn->set_tooltip_text(TTR("This variable exists in the blackboard plan.\n\nClick to open blackboard plan.")); + } else if (name_edit->get_text().begins_with("_")) { + BUTTON_SET_ICON(status_btn, theme_cache.var_private_icon); + status_btn->set_tooltip_text(TTR("Variable is private and doesn't exist in the blackboard plan.\n\nClick to open blackboard plan.")); } else { BUTTON_SET_ICON(status_btn, theme_cache.var_not_found_icon); status_btn->set_tooltip_text(TTR("No such variable exists in the blackboard plan!\n\nClick to open blackboard plan.")); @@ -142,6 +145,7 @@ void EditorPropertyVariableName::_notification(int p_what) { theme_cache.var_add_icon = LimboUtility::get_singleton()->get_task_icon(LW_NAME(LimboVarAdd)); theme_cache.var_exists_icon = LimboUtility::get_singleton()->get_task_icon(LW_NAME(LimboVarExists)); theme_cache.var_not_found_icon = LimboUtility::get_singleton()->get_task_icon(LW_NAME(LimboVarNotFound)); + theme_cache.var_private_icon = LimboUtility::get_singleton()->get_task_icon(LW_NAME(LimboVarPrivate)); } break; } } diff --git a/editor/editor_property_variable_name.h b/editor/editor_property_variable_name.h index 6a317c3..19cbe31 100644 --- a/editor/editor_property_variable_name.h +++ b/editor/editor_property_variable_name.h @@ -36,6 +36,7 @@ private: Ref var_exists_icon; Ref var_not_found_icon; Ref var_add_icon; + Ref var_private_icon; }; ThemeCache theme_cache; diff --git a/gdextension/limboai.gdextension b/gdextension/limboai.gdextension index c217cad..04747ed 100644 --- a/gdextension/limboai.gdextension +++ b/gdextension/limboai.gdextension @@ -83,3 +83,4 @@ LimboState = "res://addons/limboai/icons/LimboState.svg" LimboVarAdd = "res://addons/limboai/icons/LimboVarAdd.svg" LimboVarExists = "res://addons/limboai/icons/LimboVarExists.svg" LimboVarNotFound = "res://addons/limboai/icons/LimboVarNotFound.svg" +LimboVarPrivate = "res://addons/limboai/icons/LimboVarPrivate.svg" diff --git a/util/limbo_string_names.cpp b/util/limbo_string_names.cpp index cc2e155..bbc426f 100644 --- a/util/limbo_string_names.cpp +++ b/util/limbo_string_names.cpp @@ -98,6 +98,7 @@ LimboStringNames::LimboStringNames() { LimboVarAdd = SN("LimboVarAdd"); LimboVarExists = SN("LimboVarExists"); LimboVarNotFound = SN("LimboVarNotFound"); + LimboVarPrivate = SN("LimboVarPrivate"); LineEdit = SN("LineEdit"); Load = SN("Load"); managed = SN("managed"); diff --git a/util/limbo_string_names.h b/util/limbo_string_names.h index 8652798..d06e02d 100644 --- a/util/limbo_string_names.h +++ b/util/limbo_string_names.h @@ -113,6 +113,7 @@ public: StringName LimboVarAdd; StringName LimboVarExists; StringName LimboVarNotFound; + StringName LimboVarPrivate; StringName LineEdit; StringName Load; StringName managed;